[10.x] Display queue runtime in human readable format #47227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldyrynda
force-pushed
the
chore/queue-runtime-for-humans
branch
2 times, most recently
from
e8ada04 to
b1a3f48
Compare
|
Would like this for migrations too 🙏 |
driesvints
approved these changes
May 29, 2023
|
If I create a job and put 
|
michaeldyrynda
force-pushed
the
chore/queue-runtime-for-humans
branch
from
c5b0e9c to
8bd3353
Compare
michaeldyrynda
force-pushed
the
chore/queue-runtime-for-humans
branch
from
8bd3353 to
f7c2f55
Compare
…o type issues with string / int comparison
|
Got it; you can no longer compare a string (result of
|
|
I'm not sure why there is an (pretty sure) unrelated test failure in the Windows tests, though. |
|
@driesvints mentioned the failing test is a known intermittent failure (he re-ran for me, but still no good) The introduced functionality is otherwise working as expected now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, queue runtime is displayed in milliseconds (
mssuffix), which is fine in many scenarios where tasks are short-lived and it is clear how long a job ran.For longer running tasks, beyond say 10 seconds (
10,000.00ms), the runtime is not so easily parseable.I have had queued jobs that run for
828,320.11ms, which is difficult to reason about at a glance.This PR introduces formatting of the runtime to human-readable notation for runtimes exceeding 1sec (
1,000ms);